Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add information on myself to the list #2848

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

maryamrmz
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @maryamrmz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2848 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 923 2586

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @maryamrmz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2848 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 924 2588

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the @ from the filename. Other than that - approved!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @maryamrmz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2848 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 931 2595

@maryamrmz
Copy link
Contributor Author

maryamrmz commented Jun 9, 2023

Please remove the @ from the filename. Other than that - approved!

But I checked another files, and all of them have @!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @maryamrmz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2848 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 931 2595

@ProsperousHeart
Copy link
Member

ProsperousHeart commented Jun 10, 2023

Please remove the @ from the filename. Other than that - approved!

But I checked another files, and all of them have @!

Not all of them, no. Too many, yes. Please update as requested.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @maryamrmz, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2848 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 932 2595

@maryamrmz
Copy link
Contributor Author

Please remove the @ from the filename. Other than that - approved!

But I checked another files, and all of them have @!

Not all of them, no. Too many, yes. Please update as requested.

You're right!
I fixed that!

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ProsperousHeart ProsperousHeart merged commit 030c8c6 into zero-to-mastery:master Jun 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants