Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create file Emm-aan1.json #2831

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Create file Emm-aan1.json #2831

merged 2 commits into from
Jun 10, 2023

Conversation

Emm-aan1
Copy link
Contributor

renamed the file to match my account name

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Emm-aan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2831 15 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 918 2565

@Emm-aan1
Copy link
Contributor Author

My pull requests are not successful and u don't know why. Please help

ProsperousHeart
ProsperousHeart requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from missing the last } I believe this is ok. Please double check the main repo README.

Submissions/Emm-aan1.json Show resolved Hide resolved
@ProsperousHeart ProsperousHeart added changes requested bug Something isn't working labels Jun 9, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Emm-aan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2831 15 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 931 2595

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Emm-aan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2831 15 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 931 2595

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Emm-aan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2831 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 931 2595

ProsperousHeart
ProsperousHeart approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ProsperousHeart ProsperousHeart merged commit 41483a1 into zero-to-mastery:master Jun 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProsperousHeart ProsperousHeart ProsperousHeart approved these changes

Assignees
No one assigned
Labels
bug Something isn't working changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Emm-aan1 @ProsperousHeart