Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create @masanbasa3k.json #2817

Merged
merged 2 commits into from
May 19, 2023
Merged

Create @masanbasa3k.json #2817

merged 2 commits into from
May 19, 2023

Conversation

masanbasa3k
Copy link
Contributor

I created my json file.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @masanbasa3k, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2817 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 914 2550

@masanbasa3k
Copy link
Contributor Author

Hello, @ProsperousHeart, could you please add my name to the list? Thank you.

ProsperousHeart
ProsperousHeart requested changes May 16, 2023
View reviewed changes
Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please remove the @ from filename
  2. please ensure your country is a current country, or else it will not show on the map

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @masanbasa3k, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2817 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 916 2555

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @masanbasa3k, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2817 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 916 2555

@masanbasa3k
Copy link
Contributor Author

@ProsperousHeart Thank you for helping to me. I did the things you told me.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @masanbasa3k, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2817 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 916 2559

ProsperousHeart
ProsperousHeart approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @masanbasa3k, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2817 16 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
1 916 2559

@ProsperousHeart ProsperousHeart merged commit 88f5096 into zero-to-mastery:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProsperousHeart ProsperousHeart ProsperousHeart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masanbasa3k @ProsperousHeart