Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added my profile #2799

Merged
merged 2 commits into from
May 7, 2023
Merged

Conversation

itsarunkumar
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @itsarunkumar, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2799 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 911 2542

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove teh @ from fielname - otherwise approved

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @itsarunkumar, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2799 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 911 2542

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @itsarunkumar, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2799 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 912 2544

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Also - I believe it is best practice to have a single empty line but this does not interfere with code

@ProsperousHeart ProsperousHeart merged commit a0c22e6 into zero-to-mastery:master May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants