Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added my json file in submissions #2797

Merged
merged 4 commits into from
May 13, 2023

Conversation

Bennyno
Copy link
Member

@Bennyno Bennyno commented Apr 27, 2023

I added a .json file in the submissions folder, to be added to the job board. Thank you so much!

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2797 27 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 909 2540

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .gitpod.yml from your git cache - otherwise approved

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2797 27 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 911 2542

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2797 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 912 2544

@Bennyno
Copy link
Member Author

Bennyno commented May 5, 2023

I removed the gitpod.yml file.

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the @ from your filename and ensure your username matches the filename. Otherwise approved.

Also - I believe 1 empty line after your data is best practice, but does not interfere with code.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2797 17 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 912 2547

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2797 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 912 2547

@Bennyno
Copy link
Member Author

Bennyno commented May 7, 2023

I removed the @ from the file name, and added the empty line as best practice. Thank you.

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ProsperousHeart ProsperousHeart merged commit e3edceb into zero-to-mastery:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants