-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added my json file in submissions #2797
added my json file in submissions #2797
Conversation
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .gitpod.yml
from your git cache - otherwise approved
🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
I removed the gitpod.yml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the @
from your filename and ensure your username matches the filename. Otherwise approved.
Also - I believe 1 empty line after your data is best practice, but does not interfere with code.
🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Bennyno, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
I removed the @ from the file name, and added the empty line as best practice. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
I added a .json file in the submissions folder, to be added to the job board. Thank you so much!