Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added my name #2736

Merged
merged 4 commits into from
May 13, 2023
Merged

added my name #2736

merged 4 commits into from
May 13, 2023

Conversation

HassanNewDev
Copy link
Contributor

{
"name": "Hassan Abdi",
"img": "https://github.com/avatars/u/110099736?s=96&v=4",
"email": "mrhassanabdi1@gmail.com",
"links": {
"website": "https://myportfolio-hassandev.netlify.app/#",
"linkedin": "",
"github": "https://github.com/hassannewdev"
},
"jobTitle": "Frontend Web Developer ",
"location": {
"city": "London",
"state": "",
"country": "United Kingdom"
}
}

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 892 2485

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the filename to match your GitHub username - including casing

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 893 2490

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 893 2490

@HassanNewDev
Copy link
Contributor Author

Please update the filename to match your GitHub username - including casing

i updated my filename to match my GitHub username.

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure it also includes the proper casing for your username in your filename

@stale
Copy link

stale bot commented Apr 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.

@stale stale bot added the Stale label Apr 26, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 907 2538

@HassanNewDev
Copy link
Contributor Author

i already done that

@stale stale bot removed the Stale label Apr 28, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 910 2539

@ProsperousHeart
Copy link
Member

i already done that

image

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 910 2540

@HassanNewDev
Copy link
Contributor Author

the recent one is correct "chaned filename casing"

@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If your PR has a merge conflict, it must be resolved before it can be merged. Thank you for your contributions.

@stale stale bot added the Stale label May 9, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 913 2548

Copy link
Member

@ProsperousHeart ProsperousHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While approved, please be aware of spacing. Your last } is not properly aligned. While this specific instance won't be an issue, it can be a problem in other code.

@stale stale bot removed the Stale label May 13, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @HassanNewDev, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2736 16 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 915 2553

@ProsperousHeart ProsperousHeart merged commit 509dcbd into zero-to-mastery:master May 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants