Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Page Animation #2401

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Conversation

SaumyaKumar-09
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

include.js Outdated
{
artName: 'Loading Page',
pageLink: './Art/SaumyaKumar-09/Animation%204/index.html',
imageLink: './Art/SaumyaKumar-09/Animation%204/Gif4.mp4',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the image link with a link to a .gif or .png file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thank you!

@sophiabrandt
Copy link
Member

@SaumyaKumar-09 please remove the .mp4 file and replace it with a .gif or .png.

Make sure to adjust include.js accordingly, see comment there. Thanks.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SaumyaKumar-09, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2401 84 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 286 3246

@sophiabrandt sophiabrandt merged commit 75b483a into zero-to-mastery:master Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants