Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit for submission #2374

Merged
merged 4 commits into from
Oct 30, 2023
Merged

initial commit for submission #2374

merged 4 commits into from
Oct 30, 2023

Conversation

Suparnaen
Copy link
Contributor

initial commit for submission

@Suparnaen
initial commit for submission
90161c0 
initial commit for submission
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Suparnaen, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2374 107 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 283 3232

@LaurelineP
Copy link
Contributor

Thanks for your contribution 🙌
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Feedbacks

  • your contribution folder is not named as your github username, please correct the folder name
  • your contribution miss the modification of include.js file --> please add your details according to your changes

Acceptance criteria for a contribution

  • the contribution includes a new folder named after the author github user name in ./Art
  • the contribution includes an HTML file
    • no CSS
    • no JS
    • no embedded SVG
    • has a <link> tag to the CSS file
  • the contribution includes a CSS file
  • the contribution includes the animated file (gif) or picture (jpeg, jpg, png )
    the pictural representation must not include the browser frame, just the animation
  • the contribution includes the correct contribution's details in include.js

Please address the above feedbacks and/or unchecked acceptance criteria - if you need guidance , please refer to the README.md file.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Suparnaen, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2374 107 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 285 3239

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Suparnaen, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2374 107 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 285 3239

@Suparnaen
Feedback comments fixed
2f162f6 
1.Submission folder renamed to my github repo name.
2. Contribution details added in include.js.
Please review
@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 29, 2023
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Suparnaen A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Suparnaen A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@Suparnaen
Update include.js
d342bcd 
updated include.js to resolve merge conflict
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Suparnaen A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot zero-to-mastery-bot bot removed the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 30, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Suparnaen, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2374 114 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 286 3245

@sophiabrandt sophiabrandt merged commit 44392a5 into zero-to-mastery:master Oct 30, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Suparnaen Suparnaen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Suparnaen @LaurelineP @sophiabrandt