-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update include.js #2329
Update include.js #2329
Conversation
added info to include.js
🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Is this the same as #2320 or related? If not, then multiple files are missing. |
🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
If this is the same PR, please re-open the original one and add the required changes. |
@sophiabrandt thanks for the review. adding the missing parts of the PR #2320 didn't worked for me. This PR #2329 should have fixed this , but didn't. So i started everything from scratch an submitted the correctly named files in a new PR # 2335. Maybe you can close this PR? and sorry for the chaos ...still learning. |
@nharjes the problem is that you know have two separate PRs that are both missing one or more files - vice versa. Could you try to add the missing artwork to this PR, then? In this PR, there's only the |
🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
@sophiabrandt I added the missing files to this PR. thank you! |
* Update include.js added info to include.js * fixed missing changes
* Update include.js added info to include.js * fixed missing changes
added info to include.js