Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update include.js #2329

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Update include.js #2329

merged 2 commits into from
Oct 24, 2023

Conversation

nharjes
Copy link
Member

@nharjes nharjes commented Oct 23, 2023

added info to include.js

added info to include.js
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2329 7 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 279 3202

@sophiabrandt
Copy link
Member

Is this the same as #2320 or related?

If not, then multiple files are missing.

@sophiabrandt sophiabrandt added the question Further information is requested label Oct 24, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2329 7 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 278 3208

@sophiabrandt
Copy link
Member

If this is the same PR, please re-open the original one and add the required changes.

@nharjes
Copy link
Member Author

nharjes commented Oct 24, 2023

@sophiabrandt thanks for the review. adding the missing parts of the PR #2320 didn't worked for me. This PR #2329 should have fixed this , but didn't. So i started everything from scratch an submitted the correctly named files in a new PR # 2335. Maybe you can close this PR? and sorry for the chaos ...still learning.

@sophiabrandt
Copy link
Member

@nharjes the problem is that you know have two separate PRs that are both missing one or more files - vice versa.

Could you try to add the missing artwork to this PR, then? In this PR, there's only the include.js file, so all the other files (HTML, CSS, etc.) are missing.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @nharjes, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2329 54 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 278 3210

@nharjes
Copy link
Member Author

nharjes commented Oct 24, 2023

@sophiabrandt I added the missing files to this PR. thank you!

@sophiabrandt sophiabrandt merged commit 3d1b309 into zero-to-mastery:master Oct 24, 2023
4 checks passed
LaurelineP pushed a commit to daniel1david/Animation-Nation that referenced this pull request Oct 25, 2023
* Update include.js

added info to include.js

* fixed missing changes
LaurelineP pushed a commit to ReneDev01/Animation-Nation that referenced this pull request Oct 29, 2023
* Update include.js

added info to include.js

* fixed missing changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
2 participants