Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding my new art #2295

Merged
merged 16 commits into from
Oct 22, 2023
Merged

adding my new art #2295

merged 16 commits into from
Oct 22, 2023

Conversation

K-Wiczling
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 86 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 86 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙌
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Feedbacks

  • unresolved conflicts to fix:

Acceptance criteria for a contribution

  • the contribution includes a new folder named after the author github user name in ./Art
  • the contribution includes an HTML file
    • no CSS
    • no JS
    • no embedded SVG
    • has a <link> tag to the CSS file
  • the contribution includes a CSS file
  • the contribution includes the animated file (gif) or picture (jpeg, jpg, png )
    the pictural representation must not include the browser frame, just the animation
  • the contribution includes the correct contribution's details in include.js

include.js Show resolved Hide resolved
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 86 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 86 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 81 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 80 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @K-Wiczling, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2295 73 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 279 3185

@sophiabrandt sophiabrandt merged commit 185c9c0 into zero-to-mastery:master Oct 22, 2023
4 checks passed
LaurelineP added a commit to daniel1david/Animation-Nation that referenced this pull request Oct 25, 2023
* adding my animation

* create circle animation

* add immage

* Update include.js

I'm very sorry for my inattentiveness :/

* update fokredd

* complex animation

* add image

* test

* Update square.html

* Update square.css

---------

Co-authored-by: Sophia Brandt <16630701+sophiabrandt@users.noreply.github.com>
Co-authored-by: Laureline Paris <32878345+LaurelineP@users.noreply.github.com>
LaurelineP added a commit to ReneDev01/Animation-Nation that referenced this pull request Oct 29, 2023
* adding my animation

* create circle animation

* add immage

* Update include.js

I'm very sorry for my inattentiveness :/

* update fokredd

* complex animation

* add image

* test

* Update square.html

* Update square.css

---------

Co-authored-by: Sophia Brandt <16630701+sophiabrandt@users.noreply.github.com>
Co-authored-by: Laureline Paris <32878345+LaurelineP@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants