Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation added to art directory #2287

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Animation added to art directory #2287

merged 10 commits into from
Oct 23, 2023

Conversation

Aryan741x
Copy link
Contributor

Please combine this PR with Hacktoberfest. This general menu bar animation is meant to aid in others' viewing and understanding of it.

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 101 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3177

@LaurelineP
Copy link
Contributor

Thanks for your contribution 🙌
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedback(s)

Feedbacks

  • add modifications in include.js file
  • remove the unused pictural reprensentation file not used in the details you will provide

Acceptance criteria for a contribution

  • the contribution includes a new folder named after the author github user name in ./Art
  • the contribution includes an HTML file
    • no CSS
    • no JS
    • no embedded SVG
    • has a <link> tag to the CSS file
  • the contribution includes a CSS file
  • the contribution includes the animated file (gif) or picture (jpeg, jpg, png )
    the pictural representation must not include the browser frame, just the animation
  • the contribution includes the correct contribution's details in include.js

Please address the above feedbacks and/or unchecked acceptance criteria - if you need guidance , please refer to the README.md file.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 101 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3185

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 101 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3185

@Aryan741x
Copy link
Contributor Author

@LaurelineP ok I will change and send the pull request

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 101 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 279 3192

@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 22, 2023
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Aryan741x A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Aryan741x A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot zero-to-mastery-bot bot removed the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 22, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 108 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3192

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 108 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3192

@Aryan741x
Copy link
Contributor Author

@LaurelineP Kindly Merge this pr. As a novice on GitHub, I have made every effort to address the merge issue and completed the necessary

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 107 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3195

@Aryan741x
Copy link
Contributor Author

@LaurelineP index.html resolved

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Aryan741x, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2287 107 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 278 3202

@LaurelineP LaurelineP merged commit 0a21038 into zero-to-mastery:master Oct 23, 2023
4 checks passed
LaurelineP added a commit to daniel1david/Animation-Nation that referenced this pull request Oct 25, 2023
@Aryan741x @LaurelineP
Animation added to art directory (zero-to-mastery#2287)
7ff190d 
Co-authored-by: Laureline Paris <32878345+LaurelineP@users.noreply.github.com>
LaurelineP added a commit to ReneDev01/Animation-Nation that referenced this pull request Oct 29, 2023
@Aryan741x @LaurelineP
Animation added to art directory (zero-to-mastery#2287)
b9f281b 
Co-authored-by: Laureline Paris <32878345+LaurelineP@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurelineP LaurelineP LaurelineP left review comments

Assignees

@Aryan741x Aryan741x

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
2 participants
@Aryan741x @LaurelineP