Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tiled loader #2286

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Add a tiled loader #2286

merged 6 commits into from
Oct 29, 2023

Conversation

tmsagarofficial
Copy link
Contributor

Pls merge this when possible!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 196 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 279 3176

@LaurelineP
Copy link
Contributor

Thanks for your contribution 🙌
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedback(s)

Feedbacks

  • add modifications in include.js file

Acceptance criteria for a contribution

  • the contribution includes a new folder named after the author github user name in ./Art
  • the contribution includes an HTML file
    • no CSS
    • no JS
    • no embedded SVG
    • has a <link> tag to the CSS file
  • the contribution includes a CSS file
  • the contribution includes the animated file (gif) or picture (jpeg, jpg, png )
    the pictural representation must not include the browser frame, just the animation
  • the contribution includes the correct contribution's details in include.js

Please address the above feedbacks and/or unchecked acceptance criteria - if you need guidance , please refer to the README.md file.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 196 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 279 3185

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 196 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 279 3185

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 204 1
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3192

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 203 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3192

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 203 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 279 3192

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 203 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 283 3232

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @tmsagarofficial, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2286 203 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 285 3239

@LaurelineP LaurelineP merged commit b5bfa23 into zero-to-mastery:master Oct 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmsagarofficial tmsagarofficial

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
2 participants
@tmsagarofficial @LaurelineP