Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Square shape color changing animation #2277

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

divyansharya8826
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 277 3174

@LaurelineP
Copy link
Contributor

Thanks for your contribution 🙌
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Feedbacks

➡️ Unused pictural file and missing the contribution in include.js file

  • gif file - keep the one you will specify in the include.js file and remove the unused one
  • missing contributions in include.js file

Acceptance criteria for a contribution

  • the contribution includes a new folder named after the author github user name in ./Art
  • the contribution includes an HTML file
    • no CSS
    • no JS
    • no embedded SVG
    • has a <link> tag to the CSS file
  • the contribution includes a CSS file
  • the contribution includes the animated file (gif) or picture (jpeg, jpg, png )
    the pictural representation must not include the browser frame, just the animation
  • the contribution includes the correct contribution's details in include.js

Please address the above feedbacks and/or unchecked acceptance criteria - if you need guidance , please refer to the README.md file.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 279 3184

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 279 3184

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 279 3184

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 283 3232

@divyansharya8826
Copy link
Contributor Author

I have done all the instructions mention in the readme.md file then why my PR was not accepted yet.

@LaurelineP
Copy link
Contributor

LaurelineP commented Oct 29, 2023

@divyansharya8826
Based on the current changes in your PR and the feedback I gave you

  • gif file - keep the one you will specify in the include.js file and remove the unused one
  • missing contributions in include.js file

None of the above were changed --> see your pr changes tab
There are no changes on the include.js file ( which will be responsible to display your contribution - hence this is why your PR is still not valid
-> 2 feedbacks not addressed

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 33 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 285 3239

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @divyansharya8826, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2277 40 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 285 3239

@divyansharya8826
Copy link
Contributor Author

divyansharya8826 commented Oct 29, 2023

@divyansharya8826 Based on the current changes in your PR and the feedback I gave you

  • gif file - keep the one you will specify in the include.js file and remove the unused one
  • missing contributions in include.js file

None of the above were changed --> see your pr changes tab There are no changes on the include.js file ( which will be responsible to display your contribution - hence this is why your PR is still not valid -> 2 feedbacks not addressed

I have completed the above feedback instructions. Now, can you accept my PR.

@sophiabrandt sophiabrandt merged commit fb52e3b into zero-to-mastery:master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants