Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fayezkhan1 #2151

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Add Fayezkhan1 #2151

merged 4 commits into from
Oct 27, 2023

Conversation

Fayezkhan1
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Fayezkhan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2151 70 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 258 3092

@LaurelineP
Copy link
Contributor

LaurelineP commented Oct 15, 2023 •
edited
Loading

Thanks for your contribution 🙌 @Fayezkhan1

However this misses the include.js contribution,
could you refer to the README.md file please to add your contribution details ?

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Fayezkhan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2151 70 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 257 3095

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Fayezkhan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2151 70 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
3 257 3095

@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 15, 2023
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Fayezkhan1 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot
Copy link

⚠️ MERGE CONFLICT DETECTED!

@Fayezkhan1 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot zero-to-mastery-bot bot removed the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Oct 15, 2023
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Fayezkhan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2151 79 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 257 3095

1 similar comment
@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @Fayezkhan1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number: ➕ Line Additions: 🗑️ Line Deletions:
2151 79 0
📑 Files Changed: ⭐ Repo Stars: 🔱 Total Forks:
4 257 3095

@Fayezkhan1
Copy link
Contributor Author

Fayezkhan1 commented Oct 16, 2023 •
edited
Loading

i have updated include.js @LaurelineP
can you please review it
thanks!

@sophiabrandt sophiabrandt merged commit bc8401c into zero-to-mastery:master Oct 27, 2023
LaurelineP pushed a commit to ReneDev01/Animation-Nation that referenced this pull request Oct 29, 2023
@Fayezkhan1 @sophiabrandt @LaurelineP
Add Fayezkhan1 (zero-to-mastery#2151)
e394b88 
* Add Fayezkhan1

* added details in include.js

---------

Co-authored-by: Sophia Brandt <16630701+sophiabrandt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fayezkhan1 Fayezkhan1

Labels
Changes Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fayezkhan1 @LaurelineP @sophiabrandt