Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Favicon #1869 #1881

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

SimardeepSingh-zsh
Copy link
Contributor

No description provided.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 204 2888

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 218 2944

Copy link
Member

@MattCSmith MattCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SimardeepSingh-zsh
Thanks for the PR to improve the website by adding a favicon
Unfortunately I am not able to merge this currently as the link references a image file that does not exist.

Perhaps you could create the favicon.ico and add it to this PR, so we can merge.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 218 2943

@MattCSmith
Copy link
Member

Just checking in on this PR and noticed the PR still doesn't include and image.
If you need help please feel free to reach out in the #hacktoberfest channel over on Discord

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 248 3040

Copy link
Contributor Author

@SimardeepSingh-zsh SimardeepSingh-zsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valuable addition! Favicon provides a small yet essential touch to the project's overall user experience. It helps in branding and differentiating your website.

  • Favicon "ZTM_SimardeepSingh-zsh.ico" has been added.
  • It appears to be properly formatted and in the appropriate location.

Nice work on enhancing the project! This is a small detail, but it contributes to the overall professionalism and user-friendliness of the site.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 253 3076

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 253 3076

@MattCSmith
Copy link
Member

This is a valuable addition! Favicon provides a small yet essential touch to the project's overall user experience. It helps in branding and differentiating your website.

  • Favicon "ZTM_SimardeepSingh-zsh.ico" has been added.
  • It appears to be properly formatted and in the appropriate location.

Nice work on enhancing the project! This is a small detail, but it contributes to the overall professionalism and user-friendliness of the site.

Hey @SimardeepSingh-zsh
Unfortunately I am still unable to merge this PR and its not yet complete.
You have added the line of code on the index page for the Favicon, but it references an image that does not exist.
The favicon code must reference an actual image within the project and there is not a file called "ZTM_SimardeepSingh-zsh.ico" in your pull request or already in the project.

If you need more help with this, please reach out in our #hacktoberfest channel on Discord.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
1881 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 283 3220

@sophiabrandt
Copy link
Member

Missing file added in #2362 instead of this PR 🤷

@sophiabrandt sophiabrandt merged commit 68b7e86 into zero-to-mastery:master Oct 27, 2023
4 checks passed
LaurelineP pushed a commit to ReneDev01/Animation-Nation that referenced this pull request Oct 29, 2023
* Added Favicon #1869

* Update index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants