-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Favicon #1869 #1881
Added Favicon #1869 #1881
Conversation
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SimardeepSingh-zsh
Thanks for the PR to improve the website by adding a favicon
Unfortunately I am not able to merge this currently as the link references a image file that does not exist.
Perhaps you could create the favicon.ico and add it to this PR, so we can merge.
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Just checking in on this PR and noticed the PR still doesn't include and image. |
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a valuable addition! Favicon provides a small yet essential touch to the project's overall user experience. It helps in branding and differentiating your website.
- Favicon "ZTM_SimardeepSingh-zsh.ico" has been added.
- It appears to be properly formatted and in the appropriate location.
Nice work on enhancing the project! This is a small detail, but it contributes to the overall professionalism and user-friendliness of the site.
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Hey @SimardeepSingh-zsh If you need more help with this, please reach out in our #hacktoberfest channel on Discord. |
🙏 Thanks for your pull request @SimardeepSingh-zsh, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Missing file added in #2362 instead of this PR 🤷 |
* Added Favicon #1869 * Update index.html
No description provided.