Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #532

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Update package.json #532

merged 1 commit into from
Apr 29, 2018

Conversation

plesiecki
Copy link
Contributor

Correct module path

Correct module path
@zenorocha
Copy link
Owner

Hey @plesiecki,

Thanks for sending this pull request. Can you provide more information about why this is needed?

@plesiecki
Copy link
Contributor Author

Sure, I bundle using Rollup, looks like rollup reads module field from package.json and I got Unresolved dependencies error because src/ is "npmignored".

@Ruffio
Copy link

Ruffio commented Apr 3, 2018

@zenorocha should this PR be merged?

@zenorocha zenorocha merged commit 0fcf8c9 into zenorocha:master Apr 29, 2018
@zenorocha
Copy link
Owner

Thanks @plesiecki!

@realityking
Copy link
Contributor

I don't understand this PR. dist/clipboard.js is not an ESM module, why is it listed in the module field?

sachinchoolur pushed a commit to sachinchoolur/clipboard.js that referenced this pull request Oct 22, 2019
cdll pushed a commit to x78w/clipboard.js that referenced this pull request Jul 14, 2020
cdll added a commit to x78w/clipboard.js that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants