Language highlight with diff on markdown in articles and books #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO
|
kkiyama117
changed the title
kkiyama117
changed the title
|
@kkiyama117 |
steelydylan
reviewed
Jan 23, 2021
| @@ -33,7 +33,7 @@ | |||
| "markdown-it-inline-comments": "^1.0.1", | |||
| "markdown-it-link-attributes": "^3.0.0", | |||
| "markdown-it-task-lists": "^2.1.1", | |||
| "prismjs": "^1.22.0" | |||
| "prismjs": "^1.23.0" | |||
There was a problem hiding this comment.
Q: prismjsのマイナーバージョンの更新理由を教えていただけないでしょうか？
There was a problem hiding this comment.
A: はじめ #86 の解決に PrismJS/prism#2580 が必要かと思って試行錯誤していた時のcommitが混ざってしまってます...... 念の為手元でRevertしても特に問題なく動作しているように思われます.
There was a problem hiding this comment.
@kkiyama117 あ、なるほどですね！もし問題がありそうなら元に戻す可能性はありますが、今のところ大丈夫です！
There was a problem hiding this comment.
Revert commit を上げた方がよろしいでしょうか?
There was a problem hiding this comment.
あ、特に大丈夫ですよ！理由が気になっただけなので！
ありがとうございます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Resolves #86 .
Use the similar way with
diff-highlightplugin ofmarkdown-it-prism.Links
https://zenn.dev/kkiyama117/scraps/05094a5e9f8db8
Others
may conflict with #103.this change do not cause confliction unless you treat prism through markdown-it instance.