Stack Request cleanup and improvements #2906

bcdurak · 2024-08-06T07:25:53Z

Describe changes

WIP.

WARNING: This will require a lot of dashboard changes. Do NOT merge before contacting the frontend team.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-08-06T07:25:58Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

src/zenml/zen_server/routers/workspaces_endpoints.py

src/zenml/zen_stores/rest_zen_store.py

src/zenml/models/v2/misc/full_stack.py

schustmi · 2024-08-26T14:50:11Z

src/zenml/zen_stores/sql_zen_store.py

+                                connector_config = (
+                                    existing_service_connector.configuration
+                                )
+                                connector_config[


I know this is not a change of this PR, but do I understand this correctly: If someone creates a stack now that has any vm orchestrator in them, we secretly update the service connector to generate permanent tokens? That doesn't seem right on many levels, especially having such a flavor specific logic in the general implementation of this function?

@stefannica @avishniakov

@schustmi is not wrong, this feels very specific and doesn't belong here. I guess this was required to make it easier to implement the stack creation wizard in the UI. Perhaps we can move this logic in the UI as well.

The design-wise correct solution for this is to make this behavior dynamic, so we don't have to configure it at all. The skypilot orchestrator would simply ask the service connector explicitly to not generate temporary tokens. This is just some technical debt we inherited when we implemented the SkyPilot orchestrators. Perhaps I can pitch in this part of the implementation, doesn't seem to difficult.

Was just pointing this out, I don't we think we have to do that as part of this PR. Is it okay if I create a ticket for you @stefannica?

Yes, thanks !

src/zenml/client.py

avishniakov

🦭

bcdurak added 5 commits August 5, 2024 22:19

starting with models

ccf01bf

ez

13be51f

formatting

8ad6f2f

linting

1fdef2c

merged develop

533edfd

bcdurak requested review from schustmi and avishniakov August 6, 2024 07:25

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Aug 6, 2024

schustmi requested changes Aug 21, 2024

View reviewed changes

src/zenml/zen_server/routers/workspaces_endpoints.py Show resolved Hide resolved

src/zenml/zen_stores/rest_zen_store.py Show resolved Hide resolved

src/zenml/models/v2/misc/full_stack.py Outdated Show resolved Hide resolved

merged develop

6925dad

bcdurak marked this pull request as ready for review August 22, 2024 15:34

bcdurak added the run-slow-ci label Aug 22, 2024

bcdurak added 4 commits August 22, 2024 17:43

removed the todos for now

925d4a7

fixing some model_rebuilds and docstrings

dffc2bc

renaming the file\

5147e6e

fixing the error type

1982724

bcdurak requested a review from schustmi August 23, 2024 13:33

Merge branch 'develop' into feature/PROD-stack-request-cleanup

cbf6393

schustmi requested changes Aug 26, 2024

View reviewed changes

bcdurak requested a review from schustmi August 26, 2024 15:59

schustmi approved these changes Aug 27, 2024

View reviewed changes

avishniakov approved these changes Aug 27, 2024

View reviewed changes

bcdurak added 2 commits August 27, 2024 15:32

Merge branch 'develop' into feature/PROD-stack-request-cleanup

51aefc1

Merge branch 'develop' into feature/PROD-stack-request-cleanup

da01ec2

bcdurak merged commit 83b414f into develop Aug 27, 2024
71 checks passed

bcdurak deleted the feature/PROD-stack-request-cleanup branch August 27, 2024 20:54

avishniakov added the breaking-change label Aug 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stack Request cleanup and improvements #2906

Stack Request cleanup and improvements #2906

bcdurak commented Aug 6, 2024 •

edited by avishniakov

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

Documentation and Community

schustmi Aug 26, 2024

bcdurak Aug 26, 2024

stefannica Aug 26, 2024 •

edited

Loading

schustmi Aug 27, 2024

stefannica Aug 27, 2024

avishniakov left a comment

Stack Request cleanup and improvements #2906

Stack Request cleanup and improvements #2906

Conversation

bcdurak commented Aug 6, 2024 • edited by avishniakov Loading

Describe changes

Pre-requisites

Types of changes

coderabbitai bot commented Aug 6, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

Documentation and Community

schustmi Aug 26, 2024

Choose a reason for hiding this comment

bcdurak Aug 26, 2024

Choose a reason for hiding this comment

stefannica Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

schustmi Aug 27, 2024

Choose a reason for hiding this comment

stefannica Aug 27, 2024

Choose a reason for hiding this comment

avishniakov left a comment

Choose a reason for hiding this comment

bcdurak commented Aug 6, 2024 •

edited by avishniakov

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

stefannica Aug 26, 2024 •

edited

Loading