-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requests vulnerability #2843
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deps not installable, please check
b9637cd
to
ba148e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all Dockerized tests throw TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'
and some templates died with ModuleNotFoundError: No module named 'packaging'
5c251e8
to
f3f9301
Compare
I had to make more changes to remove our test environment dependency on the old and deprecated |
7f60510
to
bd5dcec
Compare
That didn't work either due to some other docker-compose v2 dependencies. I chose to simply install an older version of docker whenever docker-compose is also required. |
How should the users proceed in this case? One needs docker-compose to run on cloud stacks, but the package requests a higher docker version. Wouldn't it give them problems? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you probably should ask someone other than @avishniakov for a review since he's away on holiday...
Also there's a conflict to resolve |
f44953c
to
5da70c2
Compare
NLP template updates in |
Describe changes
Unpin
requests
and upgradedocker
to remediate: https://github.com/zenml-io/zenml/security/dependabot/279Related: #2716
The
docker-compose
package has been deprecated and no longer works with newer versions of thedocker
Python package. For that reason, we have to explicitly install an older version ofdocker
(and also an older version ofrequests
) whenever we need to usedocker-compose
in our CI.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes