-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow credentials expiry to be configured for service connectors #2704
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -1672,7 +1672,7 @@ def expires_in( | |||
expires_at -= datetime.timedelta(seconds=skew_tolerance) | |||
if expires_at < now: | |||
return expired_str | |||
return seconds_to_human_readable((expires_at - now).seconds) | |||
return seconds_to_human_readable(int((expires_at - now).total_seconds())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: this was previously bugged because it only returned part of the seconds remaining up to the next day instead of the total number of seconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the quick fix
Describe changes
For credentials that expire, such as AWS session tokens for example, there was previously no way to configure or update the expiration time via the CLI. This made it impossible to update a Service Connector auto-configured with an STS token auto-detected by the ZenML CLI.
This PR also removes the expiration date from the AWS Service Connector configuration because it was redundant with the configuration attribute kept in the base connector.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes