-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DB backup failures if the database version is 0.56.3 or earlier #2613
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Describe changes
The database backup and restore feature wasn't fully functional until now due to problems in the DB schema:
Moreover, even if the DB upgrade is successful, the database backup step will fail if the database backup strategy is used, and basically interrupt the entire upgrade process.
We want to avoid any unnecessary administrative operations to be incurred by ZenML users and thus we allow database backup failures to occur with earlier database versions. In these cases, the upgrade process will continue uninterrupted without a backup. Things will go back to normal (i.e. DB backup errors will be reported as failures and interrupt the upgrades) after ZenML is upgraded to the next release.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes