Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻ Use anonymous imports to register functions on chain #171

Merged
merged 2 commits into from
Dec 15, 2017
Merged

♻ Use anonymous imports to register functions on chain #171

merged 2 commits into from
Dec 15, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 15, 2017

Issue : fix #141

@nlepage nlepage added this to the 1.0.0-RC1 milestone Dec 15, 2017
@nlepage nlepage self-assigned this Dec 15, 2017
@codecov-io
Copy link

codecov-io commented Dec 15, 2017 •
edited
Loading

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #171   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          98     98           
  Lines         350    349    -1     
=====================================
- Hits          350    349    -1
Impacted Files Coverage Δ
packages/immutadot/src/seq/ChainWrapper.js 100% <ø> (ø) ⬆️
packages/immutadot/src/util/protect.js 100% <ø> (ø) ⬆️
packages/immutadot/src/core/update.js 100% <0%> (ø) ⬆️
packages/immutadot/src/core/unset.js 100% <0%> (ø) ⬆️
packages/immutadot/src/core/set.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1caf7c...b6e6341. Read the comment docs.

@nlepage nlepage changed the title Use anonymous imports to register functions on chain ♻ Use anonymous imports to register functions on chain Dec 15, 2017
@nlepage nlepage removed the 🚧 WIP label Dec 15, 2017
frinyvonnick
frinyvonnick reviewed Dec 15, 2017
View reviewed changes
misc/generate-flow.js
await writeFile(
path.resolve(nsDir, `${name}.js`),
/* eslint-disable indent */
`import { ChainWrapper } from 'seq/ChainWrapper'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

frinyvonnick
frinyvonnick approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be interesting to test this in order to avoid regression when we bring further improvements ?

@nlepage nlepage merged commit f383dd7 into master Dec 15, 2017
@nlepage nlepage deleted the enhance/141 branch December 15, 2017 17:43
frinyvonnick pushed a commit that referenced this pull request Jan 3, 2018
@nlepage @frinyvonnick
♻ Use anonymous imports to register functions on chain (#171)
de92396 
* 🔥 Remove ChainWrapper namespaces registering

* ♻️ Use anonymous imports to register chain functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

Assignees

@nlepage nlepage

Labels
🔧 enhancement
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

chain: Use anonymous imports to register functions on chain
3 participants
@nlepage @codecov-io @frinyvonnick