Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ List wild card notation #170

Merged
merged 2 commits into from
Dec 15, 2017
Merged

✨ List wild card notation #170

merged 2 commits into from
Dec 15, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 15, 2017

Issue : fix #166

@nlepage nlepage added this to the 1.0.0-RC1 milestone Dec 15, 2017
@nlepage nlepage self-assigned this Dec 15, 2017
@codecov-io
Copy link

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #170   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          98     98           
  Lines         350    354    +4     
=====================================
+ Hits          350    354    +4
Impacted Files Coverage Δ
packages/immutadot/src/path/toPath.js 100% <100%> (ø) ⬆️
packages/immutadot/src/path/apply.js 100% <100%> (ø) ⬆️
packages/immutadot/src/path/consts.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1caf7c...13f29d0. Read the comment docs.

const newObj = copy(curObj, false)
let noop = true

for (const listProp of propValue) {
const listProps = allProps ? Object.keys(newObj) : propValue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple 👌

Copy link
Contributor

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever work 👍

@nlepage nlepage merged commit 84ea1dd into master Dec 15, 2017
@nlepage nlepage deleted the feature/166 branch December 15, 2017 16:30
frinyvonnick pushed a commit that referenced this pull request Jan 3, 2018
* 🚧 Parse list wild card

* ✨ Apply list wildcard notation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path syntax: wildcard for all properties
3 participants