Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core functions #165

Merged
merged 30 commits into from
Dec 15, 2017
Merged

Add core functions #165

merged 30 commits into from
Dec 15, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 14, 2017

Description

  • array.filter
  • array.map
  • array.pop
  • array.shift
  • array.sort
  • Move math functions to lang
  • lang number functions: Run both operands into Number()
  • string.concat
  • string.padEnd
  • string.padStart
  • string.slice
  • string.substr
  • string.substring
  • string.toLocaleLowerCase
  • string.toLocaleUpperCase
  • string.toLowerCase
  • string.toUpperCase
  • string.trim
  • string.trimLeft
  • string.trimRight

Issue : #78

@nlepage nlepage added this to the 1.0.0-RC1 milestone Dec 14, 2017
@nlepage nlepage self-assigned this Dec 14, 2017
@nlepage nlepage mentioned this pull request Dec 14, 2017
4 tasks
@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #165   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          79     98   +19     
  Lines         315    350   +35     
=====================================
+ Hits          315    350   +35
Impacted Files Coverage Δ
packages/immutadot/src/seq/ChainWrapper.js 100% <ø> (ø) ⬆️
packages/immutadot/src/util/UsingWrapper.js 100% <ø> (ø) ⬆️
packages/immutadot/src/core/unset.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/reverse.js 100% <ø> (ø) ⬆️
packages/immutadot/src/lang/toggle.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/splice.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/fill.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/push.js 100% <ø> (ø) ⬆️
packages/immutadot/src/object/assign.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/unshift.js 100% <ø> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f08e6...68d40d0. Read the comment docs.

@nlepage nlepage removed the 🚧 WIP label Dec 14, 2017
* @flow
*/
const divide = convert((value, divider) => value / divider)
const divide = convert((value, divider) => Number(value) / Number(divider))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nlepage nlepage merged commit c1caf7c into master Dec 15, 2017
@nlepage nlepage deleted the feature/78_core_functions branch December 15, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants