Fix two links in CHANGELOG #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the text of two links to match the actual link.
coopergillan
commented
Jul 19, 2022
| @@ -3,13 +3,13 @@ | |||
| ## Unreleased | |||
|
|
|||
| ## v2.8.2 | |||
| * Handles ErroneousStateError, in previous versions the consumer would do several unecessary group leave/joins. The log level is also changed to WARN instead of ERROR. ([#285](https://github.com/zendesk/racecar/pull/295)) | |||
| * Handles ErroneousStateError, in previous versions the consumer would do several unecessary group leave/joins. The log level is also changed to WARN instead of ERROR. ([#295](https://github.com/zendesk/racecar/pull/295)) | |||
coopergillan
commented
Jul 19, 2022
|
|
||
| ## v2.8.1 | ||
| * Adds new ErroneousStateError to racecar in order to give more information on this new possible exception. | ||
|
|
||
| ## v2.8.0 | ||
| * Update librdkafka version from 1.8.2 to 1.9.0 by upgrading from rdkafka 0.10.0 to 0.12.0. ([#283](https://github.com/zendesk/racecar/pull/293)) | ||
| * Update librdkafka version from 1.8.2 to 1.9.0 by upgrading from rdkafka 0.10.0 to 0.12.0. ([#293](https://github.com/zendesk/racecar/pull/293)) |
There was a problem hiding this comment.
Same here: looking at the description, this should definitely be #293.
|
@leonmaia - does this change look good to you? Looks like the builds won't run unless someone kicks them off. |
|
@darena-zendesk - are you able to kick off these specs? |
deepredsky
approved these changes
Sep 22, 2022
|
@coopergillan if you rebase/recommit this should trigger the CI |
jbdietrich
approved these changes
Oct 7, 2022
jbdietrich
previously approved these changes
Oct 7, 2022
jbdietrich
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the text of two links to match the actual link.