Fix/various fixes 20220310 #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoided internal warnings in case a file is not closed - read_fasta can now process a filename in addition to streams/handles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlessioMilanese While this PR has various minor fixes, there is a major issue to address before it can be merged.
In
create_db, we sometimes have a problem with the logistic solver not converging duringclf.fit()(observed increate_db:estimate_function).I added a command line option
-N <int>to allow adjusting themax_iterparameter ofLogisticRegression. Alternatively, (or in addition), we could try catching the warning (in this PR warnings are treated as errors) and try to adjustmax_iterautomatically.