Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP.item_create() broken: sub_cmd_args doesn't get added to arg #136

Closed
zcutlip opened this issue Jun 24, 2023 · 1 comment
Closed

OP.item_create() broken: sub_cmd_args doesn't get added to arg #136

zcutlip opened this issue Jun 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@zcutlip
Copy link
Owner

zcutlip commented Jun 24, 2023

In v3.10.0 we broke item_create().

In _OPArgv.item_create_argv(), item_create_args doesn't get passed to item_generic_argv().

This causes multiple kinds of breakage:

  • --template arg is omitted
  • --generate-password arg omitted if provided
  • --vault arg omitted if provided, which breaks service accounts

Fix should be easy. May do it straight in the development branch

@zcutlip
Copy link
Owner Author

zcutlip commented Jun 24, 2023

Note: It would be great if we could devise a way to add item creation to offline automated testing so we catch these things

@zcutlip zcutlip self-assigned this Jun 24, 2023
@zcutlip zcutlip added the bug Something isn't working label Jun 24, 2023
zcutlip added a commit that referenced this issue Jun 26, 2023
Merge development into main for issue #136
@zcutlip zcutlip closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant