Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ui. #148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated ui. #148

wants to merge 4 commits into from

Conversation

orl0pl
Copy link
Contributor

@orl0pl orl0pl commented May 5, 2023

I made feature panel and search bar same size, also I made search bar more round.

@vercel
Copy link

vercel bot commented May 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview ✅ 1 resolved May 6, 2023 2:25pm

@zbycz
Copy link
Owner

zbycz commented May 6, 2023 •
edited
Loading

Hi, thanks for your PR. The ui looks like a move in a good direction, at least on desktop (similar PR here). But can you please shortly describe your motivation? Does it solve some issue? Or did you just perhaps wanted to make osmapp more beatiful? :)

I found some issues:

  1. the panel closing button on homepage is out of the searchbox.
  2. the preview closing button on mobile as well
  3. the padding of the searchbox is different then padding of map controls on the right top corner
  4. i think the left bottom corner is missing rounding.
  5. the scrollbar stopped disappearing
  6. I dont like this version on mobile, i would say the previous one was more useful - providing more space in the limited setup. I am not sure what to do there yet. Using the "signature" red searchbox only on mobile doesnt feel like a solution.

image

Overall I would need some time to decide if this is the way to move osmapp. Especially with limited time i cant invest into style revamp while there are more pressing issue like #131.

@orl0pl
this commit fixes issues from previous commit and probably adds more …
49781f3 
…issues.

- added `isMobile` media query
- redesigned homepage and feature panel
- added red background araud search bar on mobile
- changed `layerswitcher.button` from "Mapy" to "Warstwy" in polish translation
@orl0pl
fixed
2239b7d 
```
Type error: Type '{ onClick: () => void; right: true; style: { margin: string; }; }' is not assignable to type 'IntrinsicAttributes & { onClick: any; style?: {}; }'.
  Property 'right' does not exist on type 'IntrinsicAttributes & { onClick: any; style?: {}; }'.
  ```
@Flohhhhh Flohhhhh added the ui Regarding user-interface label Jun 14, 2023
@Flohhhhh Flohhhhh mentioned this pull request Jun 14, 2023
Closed
7 tasks
@Flohhhhh
Copy link
Contributor

Closing in reference to Tailwind/Headless change

@Flohhhhh Flohhhhh closed this Jun 14, 2023
@zbycz zbycz reopened this Feb 8, 2024
@zbycz zbycz mentioned this pull request Apr 17, 2024
Merged
@zbycz zbycz mentioned this pull request Sep 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui Regarding user-interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orl0pl @zbycz @Flohhhhh