iD Tagging scheme exploration #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Committed in-flight 5J814 :)
Open
# Conflicts: # yarn.lock
zbycz
commented
Jun 17, 2023
| @@ -1,8 +1,8 @@ | |||
| import { Feature } from '../services/types'; | |||
| import { roundedToDeg } from '../utils'; | |||
|
|
|||
| const getSubclass = ({ properties, osmMeta }: Feature) => | |||
| properties.subclass?.replace(/_/g, ' ') || osmMeta.type; // TODO translate ? maybe use iD editor logic (already with translations) | |||
whubsch
pushed a commit
to whubsch/osmapp
that referenced
this pull request
Jun 20, 2023
* iD Tagging scheme exploration * fix build * fix build2 * show only unique fields * add typescript types * y lintfix * find Field for rest of tags * move schema to Feature + add UI * translate values in semiCombo * titles * hack address:* in * remove tags which are already covered by Preset name * experiment - clear sessionstorage * typeCombo is usually cleared by preset.tags * We need typeCombo after all, eg node/7002486683 * move units from label to value * finalize first prototype * allow language switching * fix buildAddress a little * extract PoiDescription.tsx * extract field helpers to fields.ts * refactoring restKeys->keysTodo, added publishDbgObject(), added test * fix access key - covers multiple tags * Use `@openstreetmap/id-tagging-schema` pkg Committed in-flight 5J814 :) * fix keysTodo (never commit 30k ft above ground) * y lintfix * fix [object object] in `subject:wikidata` * update osmApi.test.ts * hide under advanced mode * add Details above TagsTable
zbycz
added a commit
to whubsch/osmapp
that referenced
this pull request
Jun 20, 2023
This reverts commit 5a492a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attemt to adopt the presets from id-tagging-schema project and show them in very simple way on FeaturePanel.
Follow-up:
TODO
Bugs: