Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc button added #119

Merged
merged 13 commits into from
Aug 27, 2022
Merged

rpc button added #119

merged 13 commits into from
Aug 27, 2022

Conversation

D3CRYPT360
Copy link
Contributor

Added RPC button to redirect to website

WARNING: This has not been tested from my part, please test before merging thanks :)

@D3CRYPT360 D3CRYPT360 marked this pull request as ready for review August 26, 2022 19:40
@OwOHamper OwOHamper self-requested a review August 26, 2022 19:54
@OwOHamper
Copy link
Collaborator

I was thinking of linking users directly to .zip since the website is kinda outdated. Anyways you should edit button title from "Download VALORANT-Rank-Yoinker" to "Download VALORANT rank yoinker".

src/rpc.py Outdated Show resolved Hide resolved
src/rpc.py Outdated Show resolved Hide resolved
@zayKenyon
Copy link
Owner

I was thinking of linking users directly to .zip since the website is kinda outdated. Anyways you should edit button title from "Download VALORANT-Rank-Yoinker" to "Download VALORANT rank yoinker".

Then we should wait until the website is done. As a user, if a button tried to download a program I'd find that super sketchy.

@zayKenyon zayKenyon added the blocked Pending another merge label Aug 26, 2022
@zayKenyon
Copy link
Owner

Pending #121

main.py Outdated Show resolved Hide resolved
@zayKenyon zayKenyon removed the blocked Pending another merge label Aug 27, 2022
@zayKenyon zayKenyon merged commit efaea3a into zayKenyon:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants