-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read_source #72
Conversation
htsinfer/get_library_source.py
Outdated
"Could not open abundance.tsv created by Kallisto quant" | ||
) from exc | ||
|
||
def _convert_dic_to_df(self) -> pd.DataFrame: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you call htsinfer.utils.convert_dict_to_df
instead?
Codecov Report
@@ Coverage Diff @@
## dev_v2 #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 602 611 +9
=========================================
+ Hits 602 611 +9
Continue to review full report at Codecov.
|
Description
Type of change
Please delete options that are not relevant.
to not work as expected)
Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes