Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no zombie processes are left over by run.sh #47

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Ensure no zombie processes are left over by run.sh #47

merged 10 commits into from
Oct 23, 2023

Commits on Oct 20, 2023

  1. safer cleaning of resources by using Popen context

    @rodja
    rodja committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6efb85d View commit details
    Browse the repository at this point in the history

  2. handling subprocess exceptions

    @rodja
    rodja committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3087960 View commit details
    Browse the repository at this point in the history

  3. explicit communication closure

    @rodja
    rodja committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    eca8e7a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Merge remote-tracking branch 'origin/main' into run-sh-zombies

    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    2871ae5 View commit details
    Browse the repository at this point in the history

  2. graceful killing of sub processes

    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    aadda68 View commit details
    Browse the repository at this point in the history

  3. check if proc exists

    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    7a7f99d View commit details
    Browse the repository at this point in the history

  4. not using sudo in docker containers 

    because it will create zombie processes (see #47)
    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    cc72d89 View commit details
    Browse the repository at this point in the history

  5. provide error message if command fails

    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    9c76266 View commit details
    Browse the repository at this point in the history

  6. do not use SIGKILL for timeout 

    because it can leave a zombie process (see #47)
    @rodja
    rodja committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    3024e48 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. code review

    @falkoschindler
    falkoschindler committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a63b155 View commit details
    Browse the repository at this point in the history