Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix any generics in zarr.array #1861

Merged
merged 2 commits into from
May 11, 2024
Merged

Fix any generics in zarr.array #1861

merged 2 commits into from
May 11, 2024

Conversation

dstansby
Copy link
Contributor

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby marked this pull request as ready for review May 10, 2024 16:05
jhamman
jhamman approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jhamman jhamman merged commit f632771 into zarr-developers:v3 May 11, 2024
18 checks passed
@dstansby dstansby deleted the any-generics-array branch May 12, 2024 08:28
@jhamman jhamman added V3 Related to compatibility with V3 spec types labels Jun 1, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
types V3 Related to compatibility with V3 spec
Projects
None yet
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @jhamman