Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pre-commit): update pre-commit versions and remove attrs dep mypy section #1848

Merged
merged 1 commit into from
May 7, 2024
Merged

chore(pre-commit): update pre-commit versions and remove attrs dep mypy section #1848

merged 1 commit into from
May 7, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 7, 2024

Tiny chore here.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

d-v-b
d-v-b approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good!

@jhamman jhamman merged commit 4f5ca4b into zarr-developers:v3 May 7, 2024
18 checks passed
@jhamman jhamman deleted the chore/update-pre-commit branch May 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @d-v-b