Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit groups #1827

Merged
merged 4 commits into from
May 7, 2024
Merged

Remove implicit groups #1827

merged 4 commits into from
May 7, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 1, 2024 •
edited
Loading

@d-v-b and I spent some time last week extracting implicit groups from the v3 code base. It actually wasn't that painful :)

closes #1797

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman
wip: more group members work
dad8ea0
@jhamman
remove implicit groups
7796e08 
refactor Group.getitem and Group.open to better handle loading members
for v2/v3
@jhamman
tidy
3d6ffeb
@jhamman
Merge branch 'v3' into v3-more-group-members
fc94f89
@jhamman jhamman added this to the 3.0.0 milestone May 7, 2024
@jhamman jhamman added the V3 Related to compatibility with V3 spec label May 7, 2024
@jhamman jhamman modified the milestones: 3.0.0, 3.0.0.alpha May 7, 2024
d-v-b
d-v-b approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jhamman jhamman merged commit 8d483c9 into zarr-developers:v3 May 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
V3 Related to compatibility with V3 spec
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @d-v-b