-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Disallow generic Any typing #1794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
v3-typing-any-generics
branch
from
April 14, 2024 08:56
4481f6a
to
d129ac0
Compare
dstansby
changed the title
Disallow generic Any typing
[v3] Disallow generic Any typing
Apr 14, 2024
jhamman
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @d-v-b, please take a look and merge if you are happy.
dstansby
force-pushed
the
v3-typing-any-generics
branch
from
April 19, 2024 07:57
d129ac0
to
f3bee41
Compare
…yping-any-generics
@dstansby I opened a PR against this branch that fixes the merge conflicts: dstansby#1 |
Fix merge conflicts for V3 typing any generics
Thanks! |
d-v-b
approved these changes
Apr 22, 2024
thanks @dstansby! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #1783. Again I've made some simple fixes, and then added an ignore list for the rest of the files that need fixing, so this PR isn't too big.