Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Disallow generic Any typing #1794

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

dstansby
Copy link
Contributor

Another part of #1783. Again I've made some simple fixes, and then added an ignore list for the rest of the files that need fixing, so this PR isn't too big.

@dstansby dstansby mentioned this pull request Apr 14, 2024
16 tasks
@dstansby dstansby marked this pull request as ready for review April 14, 2024 09:16
@dstansby dstansby changed the title Disallow generic Any typing [v3] Disallow generic Any typing Apr 14, 2024
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @d-v-b, please take a look and merge if you are happy.

@jhamman jhamman added the V3 Related to compatibility with V3 spec label Apr 19, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
@d-v-b
Copy link
Contributor

d-v-b commented Apr 22, 2024

@dstansby I opened a PR against this branch that fixes the merge conflicts: dstansby#1

Fix merge conflicts for V3 typing any generics
@dstansby
Copy link
Contributor Author

Thanks!

@d-v-b d-v-b merged commit f046322 into zarr-developers:v3 Apr 22, 2024
14 checks passed
@d-v-b
Copy link
Contributor

d-v-b commented Apr 22, 2024

thanks @dstansby!

@dstansby dstansby deleted the v3-typing-any-generics branch April 23, 2024 09:01
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types V3 Related to compatibility with V3 spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants