-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8 and numpy 1.20 #1557
Conversation
Note: green builds will require updating the GitHub settings |
this is great idea, thank you |
May have been a bit premature with 3.12...
|
This reverts commit 837854b.
All non-3.8 builds have passed. I think this is in a fine state. @jakirkham, any thoughts, after you recently added 3.12 to numcodecs but didn't drop 3.8? |
+1 on dropping 3.8 then 3.9 early next year. @joshmoore - can we help you get this over the line? |
I accepted your change, @jhamman, and merged in main. Assuming all is green, I imagine we can get this in immediately (unless we want one last pre-drop release). |
I don't think that is necessary. Let's merge when this goes green! |
@joshmoore - any idea why the last few checks have not reported back? |
Got a (big) verbal 👍 from @jakirkham. The failing jobs are due to the job configuration re: #1557 (comment) I'll merge now and bump the 3.8s to 3.9s. |
* Drop 3.8 and add 3.12 * Try removing line_profiler * Also bump the minimal numpy to 1.21 * Drop 3.12 again * Revert "Try removing line_profiler" This reverts commit 837854b. * Update release.rst --------- Co-authored-by: Joe Hamman <joe@earthmover.io> Co-authored-by: jakirkham <jakirkham@gmail.com>
Various PR builds (e.g. https://github.com/zarr-developers/zarr-python/actions/runs/6704243768/job/18216294128?pr=1543) are failing on Python 3.8. According to https://scientific-python.org/specs/spec-0000/ dropping Python 3.9 is suggested by the end of this year. As a step in that direction, this PR drops 3.8
and adds 3.12.TODO: