Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pre-commit hooks #1448

Merged
merged 3 commits into from
Dec 20, 2023
Merged

chore: update pre-commit hooks #1448

merged 3 commits into from
Dec 20, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 27, 2023 •
edited
Loading

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 27, 2023
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 4d84823 to afc26ae Compare July 25, 2023 00:39
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 4194bdf to f018e17 Compare August 8, 2023 01:50
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from dcada57 to 9b2f858 Compare August 15, 2023 01:58
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 739a816 to f69e614 Compare August 29, 2023 01:36
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 9b10876 to a18fa60 Compare September 19, 2023 02:35
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from e94d4a6 to 52997ee Compare October 9, 2023 19:18
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 6de0d2e to c629a56 Compare October 30, 2023 19:07
@dstansby dstansby mentioned this pull request Oct 31, 2023
Merged
6 tasks
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 8217077 to ac39331 Compare November 20, 2023 18:56
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Dec 11, 2023
@pre-commit-ci
chore: update pre-commit hooks
1e2646b 
updates:
- https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.0.224 → v0.1.8](astral-sh/ruff-pre-commit@v0.0.224...v0.1.8)
- [github.com/psf/black: 23.10.1 → 23.12.0](psf/black@23.10.1...23.12.0)
- [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/pre-commit/mirrors-mypy: v1.3.0 → v1.7.1](pre-commit/mirrors-mypy@v1.3.0...v1.7.1)
@joshmoore
Copy link
Member

Attempted a fix based on the pre-commit failure:

error: the argument '--force-exclude' cannot be used multiple times

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12abd4e) 99.99% compared to head (77a0686) 99.99%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   99.99%   99.99%   -0.01%     
==========================================
  Files          38       38              
  Lines       14568    14563       -5     
==========================================
- Hits        14567    14562       -5     
  Misses          1        1
Files Coverage Δ
zarr/core.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@joshmoore
Copy link
Member

What looks to be a real failure surfaced:

zarr/core.py:2539:12: E721 Do not compare types, use `isinstance()`

@joshmoore
Copy link
Member

Think this is now good, @jhamman, if you want to do the honors ;)

@jhamman jhamman merged commit b5f79dd into main Dec 20, 2023
24 checks passed
@jhamman jhamman deleted the pre-commit-ci-update-config branch December 20, 2023 21:38
jhamman pushed a commit to jhamman/zarr-python that referenced this pull request Jan 24, 2024
@pre-commit-ci @joshmoore @jhamman
chore: update pre-commit hooks (zarr-developers#1448)
d4ba12c 
* chore: update pre-commit hooks

updates:
- https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.0.224 → v0.1.8](astral-sh/ruff-pre-commit@v0.0.224...v0.1.8)
- [github.com/psf/black: 23.10.1 → 23.12.0](psf/black@23.10.1...23.12.0)
- [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/pre-commit/mirrors-mypy: v1.3.0 → v1.7.1](pre-commit/mirrors-mypy@v1.3.0...v1.7.1)

* Attempt to fix ruff

* Use isinstance

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Josh Moore <josh@openmicroscopy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmoore @jhamman