Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull command #2989

Merged
merged 1 commit into from
Sep 16, 2024
Merged

refactor: pull command #2989

merged 1 commit into from
Sep 16, 2024

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Sep 11, 2024

Description

This change refactors the pull command in packager.

Related Issue

Relates to #2969

Checklist before merging

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 97dde59
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66e85bf2ac29bd00081b0b3b

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 30.66667% with 104 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/pull.go 32.16% 72 Missing and 25 partials ⚠️
src/cmd/package.go 0.00% 7 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/pull.go 32.16% <32.16%> (ø)

... and 1 file with indirect coverage changes

@phillebaba phillebaba force-pushed the refactor/pull branch 9 times, most recently from bd88aa3 to 92516ef Compare September 12, 2024 20:00
@phillebaba phillebaba force-pushed the refactor/pull branch 2 times, most recently from b7fc174 to 45daa15 Compare September 13, 2024 22:25
src/internal/packager2/packager2.go Outdated Show resolved Hide resolved
src/cmd/package.go Outdated Show resolved Hide resolved
src/internal/packager2/packager2.go Show resolved Hide resolved
src/internal/packager2/packager2.go Outdated Show resolved Hide resolved
@phillebaba phillebaba force-pushed the refactor/pull branch 2 times, most recently from fc9f32b to 4defea3 Compare September 14, 2024 01:17
@phillebaba phillebaba marked this pull request as ready for review September 14, 2024 01:22
@phillebaba phillebaba requested review from a team as code owners September 14, 2024 01:22
@phillebaba phillebaba force-pushed the refactor/pull branch 2 times, most recently from e52806a to d7a200d Compare September 14, 2024 16:26
src/internal/packager2/pull.go Outdated Show resolved Hide resolved
src/internal/packager2/pull.go Show resolved Hide resolved
@phillebaba phillebaba force-pushed the refactor/pull branch 5 times, most recently from 972d7ba to f6a67ba Compare September 16, 2024 08:08
schristoff
schristoff previously approved these changes Sep 16, 2024
src/internal/packager2/pull.go Show resolved Hide resolved
src/internal/packager2/pull.go Show resolved Hide resolved
src/internal/packager2/pull.go Show resolved Hide resolved
Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 5e0a331 Sep 16, 2024
27 checks passed
@phillebaba phillebaba deleted the refactor/pull branch September 16, 2024 18:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants