Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mirror-resources #2975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: mirror-resources #2975

wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

Description

Re implement mirror.

Related Issue

Relates to #2969

Checklist before merging

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 0ad9799
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66e9888313b35d00081c00ee
😎 Deploy Preview https://deploy-preview-2975--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 6.62252% with 282 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/mirror.go 0.00% 133 Missing ⚠️
src/internal/packager2/load.go 6.72% 111 Missing ⚠️
src/internal/packager2/pull.go 0.00% 18 Missing ⚠️
src/cmd/package.go 0.00% 16 Missing ⚠️
src/internal/dns/dns.go 75.00% 2 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/internal/dns/dns.go 75.00% <75.00%> (ø)
src/cmd/package.go 0.00% <0.00%> (ø)
src/internal/packager2/pull.go 30.87% <0.00%> (-1.30%) ⬇️
src/internal/packager2/load.go 6.72% <6.72%> (ø)
src/internal/packager2/mirror.go 0.00% <0.00%> (ø)

@phillebaba phillebaba force-pushed the refactor/mirror branch 13 times, most recently from a13d09d to df0a073 Compare September 9, 2024 18:55
@phillebaba
Copy link
Member Author

The tests are failing because the same registry args are used for mirror-resoruces and init. Because I changed the argument to in mirror to be similar to the git server argument it no longer works with init.

@phillebaba phillebaba force-pushed the refactor/mirror branch 2 times, most recently from 94e3aea to 1672c13 Compare September 11, 2024 01:29
@phillebaba phillebaba marked this pull request as ready for review September 11, 2024 02:06
@phillebaba phillebaba requested review from a team as code owners September 11, 2024 02:06
@phillebaba phillebaba marked this pull request as draft September 11, 2024 16:16
@phillebaba phillebaba force-pushed the refactor/mirror branch 5 times, most recently from f6e1178 to b74cacb Compare September 17, 2024 10:53
@phillebaba phillebaba marked this pull request as ready for review September 17, 2024 10:55
Signed-off-by: Philip Laine <philip.laine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant