refactor: move table printing out of pkg #2942
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
refactor/printing-tables
branch
2 times, most recently
from
3a67536
to
e3e9689
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
|
I need to figure out how to pause log output for credentials in a proper way before this can be merged. |
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| switch strings.ToLower(componentName) { | ||
| case cluster.GitKey: | ||
| message.Notef("Git Server push password (username: %s):", state.GitServer.PushUsername) | ||
| fmt.Println(state.GitServer.PushPassword) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| fmt.Println(state.GitServer.PushPassword) | ||
| case cluster.GitReadKey: | ||
| message.Notef("Git Server (read-only) password (username: %s):", state.GitServer.PullUsername) | ||
| fmt.Println(state.GitServer.PullPassword) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| fmt.Println(state.ArtifactServer.PushToken) | ||
| case cluster.RegistryKey: | ||
| message.Notef("Image Registry password (username: %s):", state.RegistryInfo.PushUsername) | ||
| fmt.Println(state.RegistryInfo.PushPassword) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| fmt.Println(state.RegistryInfo.PushPassword) | ||
| case cluster.RegistryReadKey: | ||
| message.Notef("Image Registry (read-only) password (username: %s):", state.RegistryInfo.PullUsername) | ||
| fmt.Println(state.RegistryInfo.PullPassword) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Description
This change moves table printing out of pkg and into cmd. Any table printing should be specific to the CLI and should not be a concern for the exported library.
Related Issue
Depends on #2941
Relates to #2576
Checklist before merging