Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop codeql on merge queue #2934

Merged
merged 7 commits into from
Sep 14, 2024
Merged

ci: stop codeql on merge queue #2934

merged 7 commits into from
Sep 14, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Aug 27, 2024

Description

matrix jobs add to the job name which breaks the shim. Additionally, codeql can break during merge queues so we are going to stop running it in merge queues for the time being. It should be impossible for a change from a previous branch to cause a new security error in the merged branch anyway.
image

Relating issue

Fixes #2954

Checklist before merging

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners August 27, 2024 17:45
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 41e1734
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66d1e23ab2201d0008c6a3bc

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 changed the title ci: fix codeql shim ci: remove codeql from merge queue checks Aug 29, 2024
@AustinAbro321 AustinAbro321 changed the title ci: remove codeql from merge queue checks ci: stop codeql on merge queue Aug 30, 2024
AustinAbro321 and others added 5 commits August 30, 2024 11:13
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person. LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 09bdbe1 Sep 14, 2024
27 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-codeql-shim branch September 14, 2024 00:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codeql flakes during merge queues
2 participants