Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add context to renderer and remove dependency to types #2684

Closed
wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Jul 1, 2024

Description

This change refactors the Helm packager to enable the continued refactoring of other packager code. I split this into a separate PR to keep reviewing simple.

Related Issue

Relates to #2682
Part of #2694

Checklist before merging

@phillebaba phillebaba requested review from dgershman and a team as code owners July 1, 2024 19:41
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 06c4f5f
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66830692a1bde50008d527d9

@phillebaba phillebaba changed the title refactor: Helm packager refactor: add context to renderer and remove dependency to types Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 2.73973% with 71 lines in your changes missing coverage. Please review.

Project coverage is 19.03%. Comparing base (5a2ada1) to head (06c4f5f).

Files Patch % Lines
src/internal/packager/helm/post-render.go 0.00% 28 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 12 Missing ⚠️
src/internal/packager/helm/common.go 0.00% 11 Missing ⚠️
src/internal/packager/helm/chart.go 0.00% 6 Missing ⚠️
src/pkg/packager/prepare.go 0.00% 3 Missing ⚠️
src/cmd/dev.go 0.00% 2 Missing ⚠️
src/extensions/bigbang/bigbang.go 0.00% 2 Missing ⚠️
src/internal/packager/helm/zarf.go 0.00% 2 Missing ⚠️
src/pkg/packager/generate.go 0.00% 2 Missing ⚠️
src/cmd/tools/zarf.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
- Coverage   19.04%   19.03%   -0.02%     
==========================================
  Files         170      170              
  Lines       12194    12201       +7     
==========================================
  Hits         2322     2322              
- Misses       9586     9593       +7     
  Partials      286      286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phillebaba phillebaba closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant