Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the legacy E2E tests and remove them from the critical path to cutting a release #162

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix the legacy E2E tests and remove them from the critical path to cutting a release #162

merged 2 commits into from
Nov 9, 2021

Conversation

RothAndrew
Copy link
Contributor

What/Why

  • Remove a test for the docker registry from the legacy E2E tests, since that functionality already gets tested in GitHub actions
  • Remove the legacy E2E tests from the critical path to cutting a release. This is safe as long as "Require branches to be up to date before merging" is turned on and we trust the GitHub Actions pipeline to be definitive.

@RothAndrew RothAndrew self-assigned this Nov 9, 2021
YrrepNoj
YrrepNoj previously approved these changes Nov 9, 2021
View reviewed changes
@RothAndrew
Copy link
Contributor Author

/test all

@RothAndrew
Copy link
Contributor Author

/test all

@YrrepNoj YrrepNoj self-requested a review November 9, 2021 00:55
@RothAndrew RothAndrew merged commit 31740c4 into master Nov 9, 2021
@RothAndrew RothAndrew deleted the feature/fix-gitlab-e2e-and-release-pipeline branch November 9, 2021 00:56
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
@RothAndrew @jeff-mccoy
Fix the legacy E2E tests and remove them from the critical path to cu…
0392b38 
…tting a release (#162)

Signed-off-by: Jeff McCoy <code@jeffm.us>
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@RothAndrew @jeff-mccoy
Fix the legacy E2E tests and remove them from the critical path to cu…
459d106 
…tting a release (#162)

Signed-off-by: Jeff McCoy <code@jeffm.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RothAndrew @YrrepNoj