Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer survey in doc #830

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Add developer survey in doc #830

merged 3 commits into from
Aug 8, 2024

Conversation

yuxizama
Copy link
Contributor

@yuxizama yuxizama commented Aug 5, 2024

Added the developer survey banner in the most viewed docs and README page to promote the survey and gather feedback.

@yuxizama yuxizama requested a review from a team as a code owner August 5, 2024 11:50
@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
RomanBredehoft
RomanBredehoft previously approved these changes Aug 5, 2024
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

RomanBredehoft
RomanBredehoft previously approved these changes Aug 6, 2024
@yuxizama
Copy link
Contributor Author

yuxizama commented Aug 7, 2024

Hey @RomanBredehoft
I made a small adjustment yesterday and it seems like some tests have failed.
For this message below I don't really understand what happened. 😅

"@yuxizama yuxizama dismissed RomanBredehoft’s stale review via c7a6f22 18 hours ago"

Could you please help to check?
Besides, I would like to merge the same changes into the 1.6 branch so that i can be reflected on the Documentation website, but I'm not sure what's the best way to do it. Should I create another PR with these changes for 1.6 branch?
Thank you!

@RomanBredehoft
Copy link
Collaborator

Yes @yuxizama , sorry for the delay, I just committed and it should fix the issue !

And no worries for Gitub's message, in this repo we've enabled a setting which makes new commits dismiss all approval from PRs (we prefer to re-review if new changes have been made) 😉

as for 1.6 yes the idea is to open a new PR targeting the release/1.6.x branch and include the same changes !

@yuxizama
Copy link
Contributor Author

yuxizama commented Aug 8, 2024

Great @RomanBredehoft thank you so much! I'll do it for the 1.6 branch

@RomanBredehoft RomanBredehoft merged commit 62b436f into main Aug 8, 2024
16 checks passed
@RomanBredehoft RomanBredehoft deleted the developer-survey branch August 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants