Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows crash by bumping wincred #91

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

mislav
Copy link
Contributor

@mislav mislav commented May 16, 2023

For some Go applications, reading a stored credential from wincred could result in a crash because both the returned credential pointer and the error value would be nil, even though the credential technically exists in wincred storage. This was fixed upstream in the wincred library.

⚠️ Note that the minimum Go version required by danieljoos/wincred is now 1.18. The appveyor build fails as a result due to its go version go1.13.3

Fixes #53

@mikkeloscar
Copy link
Member

Thanks! @mislav

@mikkeloscar
Copy link
Member

Will remove appvoyer in #93 and fix the FreeBSD build in #94

@szuecs szuecs closed this May 17, 2023
@szuecs szuecs reopened this May 17, 2023
@szuecs
Copy link
Member

szuecs commented May 17, 2023

Ah no close/reopen does not work, you have to fetch and rebase on master branch.
We merged all the mentioned PRs.

For some Go applications, reading a stored credential from wincred could
result in a crash because both the returned credential pointer and the
error value would be nil, even though the credential technically exists
in wincred storage. This was fixed upstream in the wincred library.

Signed-off-by: Mislav Marohnić <git@mislav.net>
@mikkeloscar
Copy link
Member

I have rebased the PR

@mikkeloscar
Copy link
Member

👍

1 similar comment
@demonCoder95
Copy link
Member

👍

@szuecs szuecs merged commit b0e756d into zalando:master May 17, 2023
@mislav mislav deleted the windows-crash branch May 17, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in windowsKeychain.Get
4 participants