Support API v4 for user management #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaetan-craft Thanks for this. I'll take a look over the weekend 🙂 |
zahiar
requested changes
Jun 12, 2022
|
@gaetan-craft Thanks for this - couple of items to address & then it'll be good to merge/release 🎉 |
|
@gaetan-craft looks like some of the acceptance tests are failing, you can try and fix them or if you prefer, I can look over them when I get a chance. |
I'll give it a try in the next days |
|
@zahiar done, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User management changed a bit with v4 of graylog-server. This PRs fixes the creation and update of user in new version while keeping old version.
I'm not a seasoned go developer, feel free to suggest enhancement