Sort search results by fields #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorted result provides better visibility of the results. This is especially useful when display_search_tags option is set and search expression includes wildecards. If display_search_tags is set and search expression doesn't include wildecards, result doesn't change at all because sorting is stable-sort.
|
Yes, by default, hotdog will not perform ordering of the result, unless there is some invocations of "order_by()" in the expression. I think sorting by default makes some sense, however, at the same time, sometime we might prefer to get the result in different ordering, that is the reason why the ordering fearure has been implemented as search expressions, IIRC.... Hmm. 🤔 https://github.com/yyuu/hotdog/blob/v1.20190725.0/lib/hotdog/expression/semantics.rb#L518-L519 |
|
yes. please use this PR in anyways as you would like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorted result provides better visibility of the results. This is
especially useful when display_search_tags option is set and search
expression includes wildecards. If display_search_tags is set and search
expression doesn't include wildecards, result doesn't change at all
because sorting is stable-sort.