Modify some tests to run in single connection mode #23797
Assignees
Labels
area/ecosystem
Label for all ecosystem related projects
jira-originated
kind/new-feature
This is a request for a completely new feature
priority/high
High Priority
Comments
yugabyte-ci
added
area/ecosystem
rahulb-yb
pushed a commit
that referenced
this issue
Sep 5, 2024
…h Connection Manager Summary: Some tests test functionalities that would be requiring stickiness when run with Connection Manager. As these tests use a single connection, for the time being, allow the tests to strictly run in single connection mode until a feasible functionality change can be made. The tests include: org.yb.pgsql.YsqlUpgrade.dmlsUpdatePgCache - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.YsqlUpgrade.pinnedObjectsCacheIsUpdated - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.TestPgRegressTypesUDT.testPgRegressTypesUDT - This test creates a base_type, which requires stickiness to be supported in Connection Manager org.yb.pgsql.TestPgRegressPlanner.testPgRegressPlanner - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.TestPgRegressThirdPartyExtensionsHypopg - hypopg indexes are contained in a single backend, stickiness would be needed Jira: DB-12699 Test Plan: Jenkins: enable connection manager, test regex: .*YsqlUpgrade.dmlsUpdatePgCache|.*YsqlUpgrade.pinnedObjectsCacheIsUpdated|.*TestPgRegressTypesUDT.testPgRegressTypesUDT|.*TestPgRegressPlanner.testPgRegressPlanner|.*TestPgRegressThirdPartyExtensionsHypopg Reviewers: skumar Reviewed By: skumar Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37776
jasonyb
pushed a commit
that referenced
this issue
Sep 6, 2024
Summary: c587efd [docs] minor edit (#23796) 31e09f3 [PLAT-15029] yba installer split data and software directory setup f5ba17d [PLAT-15039]: Fix bootstrap on bi-directional xCluster config creation 578248a [#23770] YSQL: Deterministically populate catalog cache in tests with Connection Manager enabled 7b1f22a [#23799] test: Fixed PgTableSizeTest.SharedTableSize test for pg15 788434a [#18771, #21352] docdb: Fix LightweightMessage max size when parsing 02ced43 [#22821] YSQL: Preserve local limit in a multi-page read 50ff737 [#23741] docdb: Fix cloning of colocated databases with only parent table Excluded: 9889df7 [#23706] YSQL: Add table-level catcache Prometheus metrics c770d79 [#23747] MetaCache: Callback should not be called while holding the lock Excluded: 40689bc [#22150] YSQL, QueryDiagnostics: EXPLAIN (ANALYZE, DIST) support for queryDiagnostics 1655e69 [PLAT-15148]: Set XCluster Table Status to DroppedFromTarget if table in replication is dropped from target only 16262f7 [#22519] YSQL: Simplify API of the ExplicitRowLockBuffer class 6614afb [PLAT-14958][PLAT-14959] Make ssh fields optional if skipProvisioning is true 1153b56 [PLAT-14867] Make sure restart alerts don't trigger for small time updates during NTP sync bf1c7bc [PLAT-12226] Add connection pooling status to universe health check 38d8ae8 [PLAT-14805]Support adding EAR configs a180bef [#19134] YSQL, ASH: Setting ASH circular buffer size based on the number of cores 7d8fc76 Adjust heading link (#23807) 4c6cf5a [PLAT-4899]Basic validation of certificates f24eb10 [#23787] YSQL: Avoid executing conn mgr guc variables hooks for parallel workers ee18df8 [PLAT-13921] [K8] [UI] Universe action tasks are disabled after a failed shrink rr node task Excluded: dcf1821 [#23797] YSQL: Modify some tests to run in single connection mode with Connection Manager 0ac22cd [Docs] Remove Drift chat bot (#23802) 0e91003 [#22825] DocDB: Vector Index General Read Path with DummyANN e8f09b5 [PLAT-15175] Make runtime conf for skipping cluster consistency check public ee479ee Versionwarning (#23781) a05c6a3 [DB-12681] yugabyted-ui: Add Voyager commands to different Voyager phases in the UI. cc80d59 [#23777] yugabyted: updating the pg parity testcase to reflect the new gflags enabled for the pg parity feature. Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37822
rahulb-yb
pushed a commit
that referenced
this issue
Sep 9, 2024
…ng with Connection Manager Summary: This patch affects the following two tests: org.yb.pgsql.TestPgExplainAnalyzeModifyTable#testForeignKey org.yb.pgsql.TestPgExplainAnalyzeModifyTable#testUpdate In warmup mode, an assertion check on the number of "storage flush requests" being made have a mismatch between the actual and expected results. For the time being, these tests will be run exclusively without a pool of warmed up connections until a more appropriate fix can be made. Jira: DB-12699 Test Plan: Jenkins: enable connection manager, test regex: .*ExplainAnalyzeModifyTable.* Reviewers: skumar Reviewed By: skumar Subscribers: mkumar Differential Revision: https://phorge.dev.yugabyte.com/D37846
jasonyb
pushed a commit
that referenced
this issue
Sep 9, 2024
Summary: 82bca83 [DOC-453] ASH wait event table updates for 2.21.1 (#23595) 011830f [PLAT-14809][YBA CLI]Support Master Key Rotation bd39e84 [PLAT-15088] Add DB version check for connection pooling 9853daf [PLAT-14808][YBA CLI]Support edit KMS operations b02f6f7 [doc][yba] KMS and expiring tokens (#23754) 62d30d5 [PLAT-15091][PLAT-14092] Improve HA logging and backup metric 6cc5f6a Add more documentation on allowed preview flags (#23826) a28b3ec [#22301] docdb: Improve handling of large responses bc28ee8 [#23752] DocDB: Integrating hnswlib into the vector indexing framework and hnsw_tool c40fff2 copy Develop changes to stable (#23812) bf7c0b0 [#23828] docdb: Fix compile error in lwproto-test.cc Excluded: 9c1cc23 [#23707] Add table name to /metrics JSON endpoint 3de6206 [PLAT-15151]: Update autoflags based checks for xCluster/DR b7bc45e Revert "[PLAT-13800] skip setting imageBundle reference for YBM based clusters using machineImage" 35add07 [PLAT-14888]: Store PITR parmas during create DR and allow users to edit them. 3ba74e8 Fix docs for xcluster DDL flow for YCQL & onprem provider ssh user (#23827) 981415e [#23820] DocDB: Use shared memory for executing read and write pg client queries in release f20edbb Moving Driver reference to Develop section (#23683) a3f3bfe [PLAT-15209] Do not set optimized mem & tablet split gflags for YBM a95dc94 [PLAT-14801] add v2 API to list YBC Gflags metadata 06d2b8d [PLAT-15194]CLI | All outputs are returned as List instead of JSON for commands like describe 0375a68 [#23700] CDCSDK: Perform table removal from CDC stream via background thread 5d2a151 [#23797] YSQL: Stabilise PgExplainAnalyzeModifyTable tests when running with Connection Manager e62dcfd sbt Swaggergen on master to fix Uts Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Differential Revision: https://phorge.dev.yugabyte.com/D37901
jasonyb
pushed a commit
that referenced
this issue
Sep 12, 2024
… single connection mode with Connection Manager Summary: Merge resolution: - TestYsqlUpgrade.java: - dmlsUpdatePgCache: YB pg15 bea1ffb removes test pinnedObjectsCacheIsUpdated that YB master dcf1821 touches. Remove. - createPgTablegroupTableIfNotExists: YB pg15 4638d7d modifies the function. YB master dcf1821 moves it lower. Apply both. - class TableInfo: YB pg15 93f65c4 adds arrayTypeOid handling. YB master dcf1821 moves it higher. Apply both. Some tests test functionalities that would be requiring stickiness when run with Connection Manager. As these tests use a single connection, for the time being, allow the tests to strictly run in single connection mode until a feasible functionality change can be made. The tests include: org.yb.pgsql.YsqlUpgrade.dmlsUpdatePgCache - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.YsqlUpgrade.pinnedObjectsCacheIsUpdated - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.TestPgRegressTypesUDT.testPgRegressTypesUDT - This test creates a base_type, which requires stickiness to be supported in Connection Manager org.yb.pgsql.TestPgRegressPlanner.testPgRegressPlanner - This test modifies system tables, which can only be done by a superuser, requires stickiness org.yb.pgsql.TestPgRegressThirdPartyExtensionsHypopg - hypopg indexes are contained in a single backend, stickiness would be needed Jira: DB-12699 Test Plan: Jenkins: enable connection manager, test regex: .*YsqlUpgrade.dmlsUpdatePgCache|.*YsqlUpgrade.pinnedObjectsCacheIsUpdated|.*TestPgRegressTypesUDT.testPgRegressTypesUDT|.*TestPgRegressPlanner.testPgRegressPlanner|.*TestPgRegressThirdPartyExtensionsHypopg Reviewers: tfoucher Reviewed By: tfoucher Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37990
rahulb-yb
pushed a commit
that referenced
this issue
Sep 16, 2024
…with Connection Manager Summary: Some additional tests can be fixed when running with Connection Manager, using different methods. The list of the tests being fixed, along with method/reasoning of fix are stated below: [DISABLED TESTS] TestAlterTableWithConcurrentTxn.testTransactionConflictErrorCode - Disabled due to flakiness that needs further understanding. TestPgAuthorization.testRevokeLoginMidSession - Disabled until better understanding of the problem. TestPgAuthorization.testConnectionLimitDecreasedMidSession - Disabled until better understanding of the problem. PgYbHashCodeScanProjection.testScans - For this specific test, we would need to still remove connection manager debug + query logs in order to reduce flakiness, disabling test until we can make log levels configurable via common server flags. PgYbStat.testYbTerminatedQueriesMultipleCauses - Test is flaky with modifications via round robin killing of backends as the assertion check may pass or fail when checking if connection is still alive after having killed backend processes. Disabling test for now. [TESTS WITHOUT WARMUP] TestPgExplainAnalyze.testSeqScan - While running in any warmup mode, catalog read requests decrease, but not to the expected value of 0. Allow test to run in single connection mode until further analysis. TestPgExplainAnalyze.testInsertValues - While running in any warmup mode, catalog read requests decrease, but not to the expected value of 0. Allow test to run in single connection mode until further analysis. TestToastFunction.testSimple - Memory allocation is significantly higher with a pool of warmed up connections, allow the test to run with a single connection to allow metrics assertions to pass. [TESTS WITH ROUND ROBIN ALLOCATION OF WARMED UP CONNECTIONS] TestPgCostModelSeekNextEstimation.testSeekNextEstimationIndexScan - Modified to have round robin behaviour in an earlier diff, allow setUp to happen after having restarted the cluster in round robin mode. TestPgCostModelSeekNextEstimation.testSeekNextEstimationBitmapScan - Modified to have round robin behaviour in an earlier diff, allow setUp to happen after having restarted the cluster in round robin mode. Jira: DB-12674, DB-12699, DB-12741 Test Plan: Jenkins: enable connection manager, all tests Reviewers: skumar, mkumar Reviewed By: skumar Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37826
jasonyb
pushed a commit
that referenced
this issue
Sep 17, 2024
Summary: f97d7d5 [#23770] [#23797] [#23837] YSQL: Fix most non-regress tests when run with Connection Manager ee2b108 [docs] reverted PR 23909 changes (#23941) bd80f4e [#23924] DocDB: Address recent flakiness of PgGetLockStatusTest.TestGetWaitStart Excluded: f0a5db7 [#20908] YSQL: Introduce interface to optimize index non-key column updates 6556498 [#23897] xClusterDDLRepl: Support create table with partition by primary key e2b1d28 [#23363] Changing the default gflags of YSQL memory configuration. e717f43 [#23925] DocDB: Address recent regression of test PgWaitQueuesTest.MultiTabletFairness 09b7702 [#23940] YSQL: Replace copyright string from YugaByteDB to YugabyteDB add83ef [#23947] Update callhome URL to use https 69db717 Update faq page (#23704) Excluded: 063dbe5 [#23786] YSQL: yb_make_next_ddl_statement_nonincrementing Excluded: a913524 [#23859] YSQL: Remove redundant Bitmap Scan filters on partial indexes 41f5afd [PLAT-15097]: Delete System platform DB table while disabling ysql d6bbf59 [#23890] docdb: Add filtering for bootstrap intent iterators based on min_replay_txn_start_ht 0b37479 [#23770] YSQL: Stabalize TestPgExplainAnalyze#testExplainAnalyzeOptions the test with ysql connection manager Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D38123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12699
The text was updated successfully, but these errors were encountered: