Skip to content

Commit

Permalink
[BACKPORT 2.18][PLAT-14286] Potential Security Issue: Password Leak i…
Browse files Browse the repository at this point in the history
…n Application Log

Summary:
Original diff - https://phorge.dev.yugabyte.com/D35975 (553e70d)

This is more of a point fix because the node-agent java client changes are not present in this branch.

Test Plan: Created universe with passwords for ysql and ycql. Verified that passwords were redacted.

Reviewers: asharma, cwang, amalyshev

Reviewed By: cwang

Subscribers: yugaware

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36039
  • Loading branch information
nkhogen committed Jun 22, 2024
1 parent 353d2ec commit 439c628
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ private ShellResponse executeNodeAction(
commandArgs.addAll(actionArgs);
if (MapUtils.isNotEmpty(redactedVals)) {
// Create a new context as a context is immutable.
if (MapUtils.isNotEmpty(context.getRedactedVals())) {
redactedVals.putAll(context.getRedactedVals());
}
context = context.toBuilder().redactedVals(redactedVals).build();
}
return shellProcessHandler.run(commandArgs, context);
Expand Down

0 comments on commit 439c628

Please sign in to comment.